Skip to content

fix(mf): async startup e2e test #12808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahabhgk merged 1 commit into from
Jan 22, 2026
Merged

fix(mf): async startup e2e test #12808

ahabhgk merged 1 commit into from
Jan 22, 2026

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Jan 21, 2026

Summary

Workaround for async startup e2e test, need to find a better solution for mf use with type: "module"

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jan 21, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit a1ebb26
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/6970bf164fbd32000811a42f

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 21, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2026

Deploying rspack-v2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: a1ebb26
Status: ✅  Deploy successful!
Preview URL: https://921907c8.rspack-v2.pages.dev
Branch Preview URL: https://fix-mf-e2e.rspack-v2.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -71.0 B (-0.0%)
react-1k 825.3 KB -41.0 B (-0.0%)
react-5k 2.7 MB -60.0 B (-0.0%)
rome 985.8 KB +1.7 KB (0.2%)
ui-components 2.1 MB -30.0 B (-0.0%)
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: eba8f88269 | PR: #12806

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -71.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -71.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: eba8f88269 | PR: #12806

Metric Current Baseline Change
📊 Total Size 825.3 KB 825.4 KB -41.0 B (-0.0%)
📄 JavaScript 825.3 KB 825.4 KB -41.0 B (-0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: eba8f88269 | PR: #12806

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB -60.0 B (-0.0%)
📄 JavaScript 2.7 MB 2.7 MB -60.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: eba8f88269 | PR: #12806

Metric Current Baseline Change
📊 Total Size 985.8 KB 984.2 KB +1.7 KB (0.2%)
📄 JavaScript 985.8 KB 984.2 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: eba8f88269 | PR: #12806

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB -30.0 B (-0.0%)
📄 JavaScript 2.0 MB 2.0 MB -30.0 B (-0.0%)
🎨 CSS 83.0 KB 83.0 KB 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

📦 Binary Size-limit

Comparing a1ebb26 to fix: handle rs.requireActual and rs.importActual in all contexts (#12806) by 9aoy

🎉 Size decreased by 314.50KB from 48.01MB to 47.70MB (⬇️0.64%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing fix-mf-e2e (a1ebb26) with v2 (e35b8b4)

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@ahabhgk ahabhgk enabled auto-merge (squash) January 21, 2026 12:14
@ahabhgk ahabhgk merged commit 8f3e117 into v2 Jan 22, 2026
107 of 111 checks passed
@ahabhgk ahabhgk deleted the fix-mf-e2e branch January 22, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahabhgk @LingyuCoder