refactor: align IncrementalPass with rspack hooks naming #12817

hardfist · 2026-01-22T11:08:03Z

Summary

some of the IncrementalPass naming according to artifact but these artifact is actually not related to rspack pass directly, so change the naming to match rspack pass(which is nearly identical to hooks name)

Checklist

Tests updated (or not required).
Documentation updated (or not required).

github-actions · 2026-01-22T11:16:18Z

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary

Project	Total Size	Change
react-1k	825.3 KB	-16.0 B (-0.0%)
react-10k	5.7 MB	-16.0 B (-0.0%)
rome	985.8 KB	-16.0 B (-0.0%)
react-5k	2.7 MB	-16.0 B (-0.0%)
ui-components	2.1 MB	-16.0 B (-0.0%)

📋 Detailed Reports (Click to expand)

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: da8fd7c6a7 | PR: #12815

Metric	Current	Baseline	Change
📊 Total Size	825.3 KB	825.3 KB	-16.0 B (-0.0%)
📄 JavaScript	825.3 KB	825.3 KB	-16.0 B (-0.0%)
🎨 CSS	0 B	0 B	0
🌐 HTML	0 B	0 B	0
📁 Other Assets	0 B	0 B	0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: da8fd7c6a7 | PR: #12815

Metric	Current	Baseline	Change
📊 Total Size	5.7 MB	5.7 MB	-16.0 B (-0.0%)
📄 JavaScript	5.7 MB	5.7 MB	-16.0 B (-0.0%)
🎨 CSS	21.0 B	21.0 B	0
🌐 HTML	0 B	0 B	0
📁 Other Assets	0 B	0 B	0

📦 Download Diff Report: react-10k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: da8fd7c6a7 | PR: #12815

Metric	Current	Baseline	Change
📊 Total Size	985.8 KB	985.9 KB	-16.0 B (-0.0%)
📄 JavaScript	985.8 KB	985.9 KB	-16.0 B (-0.0%)
🎨 CSS	0 B	0 B	0
🌐 HTML	0 B	0 B	0
📁 Other Assets	0 B	0 B	0

📦 Download Diff Report: rome Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: da8fd7c6a7 | PR: #12815

Metric	Current	Baseline	Change
📊 Total Size	2.7 MB	2.7 MB	-16.0 B (-0.0%)
📄 JavaScript	2.7 MB	2.7 MB	-16.0 B (-0.0%)
🎨 CSS	21.0 B	21.0 B	0
🌐 HTML	0 B	0 B	0
📁 Other Assets	0 B	0 B	0

📦 Download Diff Report: react-5k Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: da8fd7c6a7 | PR: #12815

Metric	Current	Baseline	Change
📊 Total Size	2.1 MB	2.1 MB	-16.0 B (-0.0%)
📄 JavaScript	2.0 MB	2.0 MB	-16.0 B (-0.0%)
🎨 CSS	83.0 KB	83.0 KB	0
🌐 HTML	0 B	0 B	0
📁 Other Assets	0 B	0 B	0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

cloudflare-workers-and-pages · 2026-01-22T11:18:16Z

Deploying rspack-v2 with Cloudflare Pages

Latest commit:	`c0d989b`
Status:	✅ Deploy successful!
Preview URL:	https://0e713067.rspack-v2.pages.dev
Branch Preview URL:	https://yj-refactor-pass.rspack-v2.pages.dev

View logs

github-actions · 2026-01-22T11:19:55Z

📦 Binary Size-limit

Comparing c0d989b to release: version 2.0.0-alpha.0 (#12815) by harpsealjs

🎉 Size decreased by 2.38KB from 47.70MB to 47.70MB (⬇️0.00%)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d120117924

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/rspack/src/config/normalization.ts

Copilot

Pull request overview

This PR refactors the naming of IncrementalPass properties to align with rspack/webpack hooks naming conventions instead of internal artifact names. The changes provide better clarity by matching the incremental pass names with their corresponding webpack compilation lifecycle hooks.

Changes:

Renamed five incremental pass properties: make → buildModuleGraph, inferAsyncModules/providedExports/dependenciesDiagnostics → finishModules, sideEffects → optimizeDependencies, and chunksRender → chunkAsset
Updated all Rust code, TypeScript types, bindings, documentation, and test snapshots to use the new naming
Added comprehensive documentation comments in Rust code linking to webpack hooks for reference

Reviewed changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
crates/rspack_core/src/incremental/mod.rs	Core bitflags definition with new pass names and helpful webpack hook references
packages/rspack/src/config/types.ts	TypeScript type definitions updated with new property names
packages/rspack/src/config/normalization.ts	Normalization logic updated for 'safe' preset configuration
packages/rspack/src/config/defaults.ts	Default values updated to use new pass names
website/docs/en/config/incremental.mdx	English documentation updated with new naming
website/docs/zh/config/incremental.mdx	Chinese documentation updated with new naming
crates/rspack_core/src/artifacts/*.rs	All artifact implementations updated to use new pass constants
crates/rspack_plugin_javascript/src/plugin/*.rs	Plugin implementations updated with new pass names and logger names
crates/rspack_binding_api/src/raw_options/raw_experiments/raw_incremental.rs	Binding API updated to use new field names
tests/rspack-test/defaultsCases/default/base.js	Test snapshot updated with new property names
crates/rspack/tests/snapshots/defaults__default_options.snap	Snapshot test updated
crates/node_binding/napi-binding.d.ts	NAPI TypeScript bindings updated
packages/rspack/etc/core.api.md	API documentation updated

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/rspack/src/config/normalization.ts

website/docs/en/config/incremental.mdx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

website/docs/en/config/incremental.mdx

codspeed-hq · 2026-01-22T11:53:11Z

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark¹

_{Comparing yj/refactor-pass (c0d989b) with main (da8fd7c)}

1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

github-actions bot added release: refactor team The issue/pr is created by the member of Rspack. labels Jan 22, 2026

hardfist changed the title ~~refactor: refactor IncrementalPass~~ refactor: align IncrementalPass with rspack hooks naming Jan 22, 2026

hardfist marked this pull request as ready for review January 22, 2026 11:18

hardfist requested a review from h-a-n-a as a code owner January 22, 2026 11:19

Copilot AI review requested due to automatic review settings January 22, 2026 11:19

Copilot started reviewing on behalf of hardfist January 22, 2026 11:19 View session

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

packages/rspack/src/config/normalization.ts Outdated Show resolved Hide resolved

refactor: refactor IncrementalPass

722b7f5

hardfist force-pushed the yj/refactor-pass branch from d120117 to 722b7f5 Compare January 22, 2026 11:22

Copilot AI reviewed Jan 22, 2026

View reviewed changes

packages/rspack/src/config/normalization.ts Outdated Show resolved Hide resolved

website/docs/en/config/incremental.mdx Show resolved Hide resolved

website/docs/en/config/incremental.mdx Outdated Show resolved Hide resolved

Apply suggestion from @Copilot

2c06adf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

hardfist commented Jan 22, 2026

View reviewed changes

website/docs/en/config/incremental.mdx Outdated Show resolved Hide resolved

Apply suggestion from @hardfist

c0d989b

hardfist enabled auto-merge (squash) January 22, 2026 12:08

stormslowly approved these changes Jan 22, 2026

View reviewed changes

hardfist merged commit 160ef7c into main Jan 22, 2026
75 of 77 checks passed

hardfist deleted the yj/refactor-pass branch January 22, 2026 13:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: align IncrementalPass with rspack hooks naming #12817

refactor: align IncrementalPass with rspack hooks naming #12817

Uh oh!

hardfist commented Jan 22, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 22, 2026 •

edited

Loading

📁 react-1k

📁 react-10k

📁 rome

📁 react-5k

📁 ui-components

Uh oh!

cloudflare-workers-and-pages bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor: align IncrementalPass with rspack hooks naming #12817

refactor: align IncrementalPass with rspack hooks naming #12817

Uh oh!

Conversation

hardfist commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related links

Checklist

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rsdoctor Bundle Diff Analysis

📁 react-1k

📁 react-10k

📁 rome

📁 react-5k

📁 ui-components

Uh oh!

cloudflare-workers-and-pages bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rspack-v2 with Cloudflare Pages

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Jan 22, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hardfist commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading