Skip to content

chore(ci): read size limit threshold from env variable #12822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hardfist merged 1 commit into from
Jan 24, 2026
Merged

chore(ci): read size limit threshold from env variable #12822

hardfist merged 1 commit into from
Jan 24, 2026

Conversation

@stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Jan 23, 2026

Summary

For easy adjustment of the threshold

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 23, 2026 06:08
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 23, 2026
Copilot AI reviewed Jan 23, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI workflow to make the size limit threshold configurable through an environment variable, allowing for easier adjustment without modifying the workflow file directly.

Changes:

  • Modified the size-threshold parameter to read from an environment variable with a fallback to the existing hardcoded value

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 825.5 KB 0
react-5k 2.7 MB 0
rome 985.9 KB 0
ui-components 2.3 MB 0

Generated by Rsdoctor GitHub Action

@stormslowly stormslowly changed the title chore(CI): read size limit threahold from env variable chore(ci): read size limit threahold from env variable Jan 23, 2026
@stormslowly stormslowly changed the title chore(ci): read size limit threahold from env variable chore(ci): read size limit threshold from env variable Jan 23, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing 7dd25c8 to fix(template): add @rspack/dev-server to dev dependencies (#12821) by harpsealjs

🙈 Size remains the same at 47.70MB

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 23, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing chore/size_limit_use_env_var (7dd25c8) with main (8931e11)

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@stormslowly stormslowly requested a review from hardfist January 23, 2026 06:33
@stormslowly stormslowly force-pushed the chore/size_limit_use_env_var branch from 91343d0 to 7dd25c8 Compare January 23, 2026 06:39
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 23, 2026

Deploying rspack-v2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7dd25c8
Status: ✅  Deploy successful!
Preview URL: https://00ee7be3.rspack-v2.pages.dev
Branch Preview URL: https://chore-size-limit-use-env-var.rspack-v2.pages.dev

View logs

@hardfist hardfist merged commit dd3e16c into main Jan 24, 2026
75 of 77 checks passed
@hardfist hardfist deleted the chore/size_limit_use_env_var branch January 24, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@hardfist hardfist hardfist approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stormslowly @hardfist