Skip to content

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Jan 26, 2026

Cherry-pick of #12825 to v1.x branch.

When Rspack's extractSourceMap passes an unnormalized path (containing .., e.g., `a/b/../c/index.js`) as `fileDependencies` to Watchpack, it triggers an unnecessary rebuild immediately after start because of the fileDependencies (unnormalized path) and the file been scanned (normalized path) string mismatch that falsely signals a `"initial-missing"` event
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 26, 2026
@cloudflare-workers-and-pages
Copy link

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 89c7df6
Status: ✅  Deploy successful!
Preview URL: https://faeb1fce.rspack-v2.pages.dev
Branch Preview URL: https://cherry-pick-12825-to-v1-x.rspack-v2.pages.dev

View logs

@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing 89c7df6 to fix(mf): use dynamic exports type for MF modules (#12841) by Gengkun

🎉 Size decreased by 330.50KB from 48.33MB to 48.01MB (⬇️0.67%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 26, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing cherry-pick-12825-to-v1.x (89c7df6) with main (b726ec5)2

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

  2. No successful run was found on v1.x (ebdfb97) during the generation of this report, so main (b726ec5) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ahabhgk ahabhgk enabled auto-merge (squash) January 26, 2026 10:50
@ahabhgk ahabhgk merged commit 2415a21 into v1.x Jan 26, 2026
52 of 53 checks passed
@ahabhgk ahabhgk deleted the cherry-pick-12825-to-v1.x branch January 26, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants