Skip to content

fix: enable panic backtrace for release-debug #12854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hardfist merged 1 commit into from
Jan 27, 2026
Merged

fix: enable panic backtrace for release-debug #12854

hardfist merged 1 commit into from
Jan 27, 2026

Conversation

@hardfist
Copy link
Contributor

@hardfist hardfist commented Jan 27, 2026 •
edited
Loading

Summary

  • before
image
  • after
image

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 27, 2026 03:32
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 27, 2026
@hardfist hardfist changed the title chore: enable backtrace for release-debug chore: enable panic backtrace for release-debug Jan 27, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 27, 2026

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0897e93
Status: ✅  Deploy successful!
Preview URL: https://986f8925.rspack-v2.pages.dev
Branch Preview URL: https://yj-release-debug.rspack-v2.pages.dev

View logs

@hardfist hardfist changed the title chore: enable panic backtrace for release-debug fix: enable panic backtrace for release-debug Jan 27, 2026
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jan 27, 2026
Copilot AI reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables the color-backtrace feature for the release-debug profile in the node binding build script. The release-debug profile is a development-oriented profile that inherits from dev but with higher optimization levels, making it appropriate to include enhanced backtrace capabilities for debugging purposes.

Changes:

  • Modified the build script to enable color-backtrace feature when building with the release-debug profile, alongside the existing support for dev profile

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hardfist hardfist enabled auto-merge (squash) January 27, 2026 03:35
Copilot AI mentioned this pull request Jan 27, 2026
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

📦 Binary Size-limit

Comparing 0897e93 to fix(mf): prevent entry-specific chunks from polluting manifest assets and refactor manifest generation (#12836) by Hanric

🎉 Size decreased by 336.25KB from 48.34MB to 48.01MB (⬇️0.68%)

@hardfist hardfist disabled auto-merge January 27, 2026 03:46
@hardfist hardfist merged commit 0a3be0a into v1.x Jan 27, 2026
55 of 58 checks passed
@hardfist hardfist deleted the yj/release-debug branch January 27, 2026 03:46
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 27, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing yj/release-debug (0897e93) with main (3d548a8)1

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark2

Footnotes

  1. No successful run was found on v1.x (2415a21) during the generation of this report, so main (3d548a8) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@hardfist hardfist mentioned this pull request Jan 27, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@quininer quininer quininer approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hardfist @quininer