chore(test): remove rust flaky test #12914
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes flaky timing-based tests from three iterator consumer utility modules. These tests attempted to verify parallelism benefits by comparing wall-clock execution times, which is unreliable due to OS thread scheduling variations.
Changes:
- Removed
time_checktest from rayon_fut.rs module - Removed
time_checktest from rayon.rs module - Removed
time_checktest from future.rs module
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/rspack_core/src/utils/iterator_consumer/rayon_fut.rs | Removed flaky timing test for parallel future consumption with rayon iterators |
| crates/rspack_core/src/utils/iterator_consumer/rayon.rs | Removed flaky timing test for parallel consumption with rayon iterators |
| crates/rspack_core/src/utils/iterator_consumer/future.rs | Removed flaky timing test for future consumption with standard iterators |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🙈 Size remains the same at 48.27MB |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Summary
Wall-clock time is not a reliable signal for asserting parallelism benefits, as OS thread scheduling can cause flaky results.
Related links
Checklist