Add checks for "navigator.language/s" to tests for "emulation.setLocaleOverride" command.#55453
Closed
lutien wants to merge 5 commits intoweb-platform-tests:masterfrom
Closed
Conversation
…leOverride" command.
6 tasks
juliandescottes
requested changes
Oct 16, 2025
Contributor
juliandescottes
left a comment
There was a problem hiding this comment.
Thanks Sasha, I feel like there is something wrong with the usage of the fixture to check the default values. It probably predates the PR, but can you check?
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
juliandescottes
approved these changes
Oct 16, 2025
Contributor
juliandescottes
left a comment
There was a problem hiding this comment.
Thanks Sasha, LGTM, one minor suggestion.
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
Contributor
Author
|
Closing in favour of #55768. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests to illustrate how the API will work for the PR in the html spec.
More tests will be updated during work on https://bugzilla.mozilla.org/show_bug.cgi?id=1994396.