fix: respect the errorStack option in stats output

samarthsinh2660 · web-flow · commit 3bd18bbc2210 · 2025-12-23T01:39:25.000+03:00
diff --git a/.changeset/empty-wasps-appear.md b/.changeset/empty-wasps-appear.md
@@ -0,0 +1,5 @@
+---
+"webpack": patch
+---
+
+Respect the `stats.errorStack` option in stats output.
diff --git a/lib/stats/DefaultStatsFactoryPlugin.js b/lib/stats/DefaultStatsFactoryPlugin.js
@@ -507,8 +507,8 @@ const EXTRACT_ERROR = {
 			object.details = /** @type {WebpackError} */ (error).details;
 		}
 	},
-	errorStack: (object, error) => {
-		if (typeof error !== "string") {
+	errorStack: (object, error, _context, { errorStack }) => {
+		if (typeof error !== "string" && errorStack) {
 			object.stack = error.stack;
 		}
 	},
diff --git a/test/__snapshots__/StatsTestCases.basictest.js.snap b/test/__snapshots__/StatsTestCases.basictest.js.snap
@@ -1178,6 +1178,27 @@ chunk (runtime: a) a.js (a) X bytes [entry] [rendered]
 webpack x.x.x compiled successfully in X ms"
 `;
 
+exports[`StatsTestCases should print correct stats for error-stack-disabled-error 1`] = `
+"asset main.js X KiB [emitted] (name: main)
+./index.js X bytes [built] [code generated]
+
+ERROR in Test error with stack
+
+webpack x.x.x compiled with 1 error in X ms"
+`;
+
+exports[`StatsTestCases should print correct stats for error-stack-enabled-error 1`] = `
+"asset main.js X KiB [emitted] (name: main)
+./index.js X bytes [built] [code generated]
+
+ERROR in Test error with stack
+Error: Test error with stack
+    at Test.js:1:1
+    at compile.js:2:2
+
+webpack x.x.x compiled with 1 error in X ms"
+`;
+
 exports[`StatsTestCases should print correct stats for errors-space-error 1`] = `
 "assets by status X bytes [cached] 1 asset
 ./loader.js!./index.js X bytes [built] [code generated] [2 errors]
diff --git a/test/statsCases/error-stack-disabled-error/index.js b/test/statsCases/error-stack-disabled-error/index.js
@@ -0,0 +1 @@
+// Empty entry - errors are added via plugin
diff --git a/test/statsCases/error-stack-disabled-error/webpack.config.js b/test/statsCases/error-stack-disabled-error/webpack.config.js
@@ -0,0 +1,22 @@
+"use strict";
+
+const { WebpackError } = require("../../../");
+
+/** @type {import("../../../").Configuration} */
+module.exports = {
+	mode: "development",
+	entry: "./index.js",
+	stats: {
+		errorStack: false
+	},
+	plugins: [
+		(compiler) => {
+			compiler.hooks.compilation.tap("Test", (compilation) => {
+				const err = new WebpackError("Test error with stack");
+				err.stack =
+					"Error: Test error with stack\n    at Test.js:1:1\n    at compile.js:2:2";
+				compilation.errors.push(err);
+			});
+		}
+	]
+};
diff --git a/test/statsCases/error-stack-enabled-error/index.js b/test/statsCases/error-stack-enabled-error/index.js
@@ -0,0 +1 @@
+// Empty entry - errors are added via plugin
diff --git a/test/statsCases/error-stack-enabled-error/webpack.config.js b/test/statsCases/error-stack-enabled-error/webpack.config.js
@@ -0,0 +1,22 @@
+"use strict";
+
+const { WebpackError } = require("../../../");
+
+/** @type {import("../../../").Configuration} */
+module.exports = {
+	mode: "development",
+	entry: "./index.js",
+	stats: {
+		errorStack: true
+	},
+	plugins: [
+		(compiler) => {
+			compiler.hooks.compilation.tap("Test", (compilation) => {
+				const err = new WebpackError("Test error with stack");
+				err.stack =
+					"Error: Test error with stack\n    at Test.js:1:1\n    at compile.js:2:2";
+				compilation.errors.push(err);
+			});
+		}
+	]
+};

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"webpack": patch
 +---
++
 +Respect the `stats.errorStack` option in stats output.
Original file line number	Diff line number	Diff line change
`@@ -507,8 +507,8 @@ const EXTRACT_ERROR = {`
`507`	`507`	`object.details = /** @type {WebpackError} */ (error).details;`
`508`	`508`	`}`
`509`	`509`	`},`
`510`		`- errorStack: (object, error) => {`
`511`		`- if (typeof error !== "string") {`
	`510`	`+ errorStack: (object, error, _context, { errorStack }) => {`
	`511`	`+ if (typeof error !== "string" && errorStack) {`
`512`	`512`	`object.stack = error.stack;`
`513`	`513`	`}`
`514`	`514`	`},`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+// Empty entry - errors are added via plugin`