fix: use RuntimeKey instead of Runtime for export generation#20346
Merged
alexander-akait merged 7 commits intomainfrom Jan 26, 2026
Merged
fix: use RuntimeKey instead of Runtime for export generation#20346alexander-akait merged 7 commits intomainfrom
alexander-akait merged 7 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 938944a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is packaged and the instant preview is available (3a73621). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@3a73621
yarn add -D webpack@https://pkg.pr.new/webpack@3a73621
pnpm add -D webpack@https://pkg.pr.new/webpack@3a73621 |
CodSpeed Performance ReportMerging this PR will improve performance by 27.82%Comparing Summary
Performance Changes
|
| * @property {Map<RuntimeSpec, Record<string, string>>=} exportsFinalNameByRuntime | ||
| * @property {Map<RuntimeSpec, string>=} exportsSourceByRuntime | ||
| * @property {Map<string, Record<string, string>>=} exportsFinalNameByRuntime | ||
| * @property {Map<string, string>=} exportsSourceByRuntime |
Member
There was a problem hiding this comment.
Is the expected change?
Member
Author
There was a problem hiding this comment.
Yeah, getRuntimeKey return string.
Member
Author
|
Added the test. But we need to merge #20350 first to fix an issue in the ESM test runner. |
Member
|
@hai-x let's rebase 😄 |
Member
Author
alexander-akait
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20332.
What kind of change does this PR introduce?
In RuntimeSpecSet, we deduplicate runtimes by
RuntimeKey, so no extra runtimes are stored here when it have sameRuntimeKey.However, when a concatenated module is generated in different chunks that share the same runtime value (equal in value but not the same reference), we still need to generate the export statement. To ensure it, we should use
RuntimeKeyto make sure that no runtimes are missing.Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No