lazy initialization of AppEngineWebAppContext for HttpConnector mode#271
Merged
copybara-service[bot] merged 1 commit intomainfrom Sep 11, 2024
Merged
Conversation
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
ludoch
approved these changes
Sep 11, 2024
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
…pConnector PiperOrigin-RevId: 673417705 Change-Id: Ic82e10f6bdc52cf40b07ba747a1ab2bfd2d92263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppEngineWebAppContextshould not be created until we are in the scope of the first request so theApiProxy.Environmentis set for initialization. This is also how it is currently done in the RPC mode but early initialization was done for HTTP mode.ServletEngineAdapter.setSessionStoreFactorybecause it is not used or implemented anymore.