Remove 10GB Cache Size Limit for Cache Service V2#2118
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the 10GB cache size limit for Cache Service V2 and improves error handling by allowing more specific error messages from the results backend.
- Remove the client-side 10GB cache size validation check that was preventing large cache uploads
- Add a new
FinalizeCacheErrorexception class for better error categorization - Update error handling to display specific error messages from the backend instead of generic ones
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/cache/src/cache.ts | Remove size limit validation, add FinalizeCacheError class, improve error message handling |
| packages/cache/tests/saveCacheV2.test.ts | Remove size limit test, add tests for large caches and specific error messages, update mocks |
| packages/cache/tests/saveCache.test.ts | Update mock to include message field for API response consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove size limit for individual caches on upload, allow for more specific error codes from results backend.