Fix: fallback to typeof when toString is applied to incompatible object#16017
Merged
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55610/ |
liuxingbaoyu
approved these changes
Oct 5, 2023
nicolo-ribaudo
approved these changes
Oct 9, 2023
| return Function.toString.call(fn).indexOf("[native code]") !== -1; | ||
| } catch (e) { | ||
| // Firefox 31 throws when "toString" is applied to an HTMLElement | ||
| return typeof fn === "function"; |
Member
There was a problem hiding this comment.
This is safe because on user-defined Function.toString never throws, right?
Contributor
Author
There was a problem hiding this comment.
I think so, Function.toString will throw a type error if the input is neither object nor function, unless there are more browser quirks we are unaware of.
According to this SO issue, Function.toString throws on HTMLElement because at that time they were not inherited from Object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox 31 will throw when
toStringis applied to an HTMLElement. Here we handle the error as suggested in #12609 (comment).