#420: fix detection of java version when JAVA_TOOL_OPTIONS is set#426
#420: fix detection of java version when JAVA_TOOL_OPTIONS is set#426slachiewicz merged 1 commit intocodehaus-plexus:masterfrom glhez:master
Conversation
slawekjaranowski
left a comment
There was a problem hiding this comment.
I would like to simplify it, as example in issue.
so split output by lines and find first line starting with javac
|
I don't see what you means and I can't work on that now (PC broken and I don't want to mess with the one I use now). The loop seems "difficult", but as far as I remember, I looked for the error message in JDK and calls here : https://github.com/openjdk/jdk/blob/81e43114eca5199a0d816c02f50ecb6bc370135b/src/hotspot/share/runtime/arguments.cpp#L3074 I am more or less doing a job of removing the line sent by Another alternative I did not try would be probably to remove the offending env variable which might or not requires a patch to https://codehaus-plexus.github.io (if that's the good repo) or avoid inheriting them. |
|
Please look at: maybe checking only standard output will be easier |
|
Ok. javac -version output to stdout, java -version to stderr... I fixed it to only read stdout like apache/maven-jar-plugin#471 |
This is not true for javac 1.8.0_472 and this fix will not work for this version. It outputs to stderr. |
right ... |
|
next test - everything on stderr |
This fix the issue I had at work (#420) by ignoring the "Picked up" based on what the JDK outputs.