Skip to content

Bump Ktlint to 1.7.1#2555

Merged
Goooler merged 3 commits intomainfrom
g/20250715/ktlint
Jul 22, 2025
Merged

Bump Ktlint to 1.7.1#2555
Goooler merged 3 commits intomainfrom
g/20250715/ktlint

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Jul 15, 2025

No description provided.

Goooler
Goooler commented Jul 15, 2025
View reviewed changes
@Goooler Goooler force-pushed the g/20250715/ktlint branch from 14bd6b4 to 17b151f Compare July 15, 2025 07:23
@Goooler
Copy link
Member Author

Goooler commented Jul 15, 2025 •
edited
Loading

Strange! The test failed in the Maven plugin but the Gradle plugin

spotless/plugin-maven/src/test/java/com/diffplug/spotless/maven/kotlin/KtlintTest.java

Lines 79 to 92 in 3893580

@Test
void testWithCustomRuleSetApply() throws Exception {
writePomWithKotlinSteps("<ktlint>\n" +
" <customRuleSets>\n" +
" <value>io.nlopez.compose.rules:ktlint:0.4.16</value>\n" +
" </customRuleSets>\n" +
" <editorConfigOverride>\n" +
" <ktlint_function_naming_ignore_when_annotated_with>Composable</ktlint_function_naming_ignore_when_annotated_with>\n" +
" </editorConfigOverride>\n" +
"</ktlint>");
setFile("src/main/kotlin/Main.kt").toResource("kotlin/ktlint/listScreen.dirty");
ProcessRunner.Result result = mavenRunner().withArguments("spotless:check").runHasError();
Assertions.assertThat(result.toString()).contains("Composable functions that return Unit should start with an uppercase letter.");
} 

java.lang.AssertionError: 
Expecting actual:
  "> arguments: [sh, -c, ./mvnw -e spotless:check]
exit code: 1
   stdout: (below)
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building Spotless Maven Plugin Tests 1.0.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- spotless-maven-plugin:2.45.1-SNAPSHOT:check (default-cli) @ spotless-maven-plugin-tests ---
[INFO] Index file does not exist. Fallback to an empty index
[ERROR] Step 'ktlint' found problem in 'Main.kt':
com/pinterest/ktlint/rule/engine/core/api/Rule$OnlyWhenEnabledInEditorconfig
java.lang.NoClassDefFoundError: com/pinterest/ktlint/rule/engine/core/api/Rule$OnlyWhenEnabledInEditorconfig
  at java.base/java.lang.ClassLoader.defineClass1(Native Method)
  at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
  at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
  at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:524)
  at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427)
  at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421)
  at java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
  at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420)
  at com.diffplug.spotless.FeatureClassLoader.findClass(FeatureClassLoader.java:79)
  at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
  at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
  at com.pinterest.ktlint.ruleset.standard.StandardRuleSetProvider.getRuleProviders$lambda$61(StandardRuleSetProvider.kt:171)
  at com.pinterest.ktlint.rule.engine.core.api.RuleProvider$Companion.invoke(RuleProvider.kt:41)
  at com.pinterest.ktlint.ruleset.standard.StandardRuleSetProvider.getRuleProviders(StandardRuleSetProvider.kt:171)
  at com.diffplug.spotless.glue.ktlint.compat.KtLintCompat1Dot0Dot0Adapter.lambda$format$0(KtLintCompat1Dot0Dot0Adapter.java:93)

@nedtwigg
Copy link
Member

nedtwigg commented Jul 16, 2025

I wonder if it's related to <customRuleSets> or io.nlopez.compose.rules:ktlint:0.4.16

@mrmans0n
Copy link

mrmans0n commented Jul 16, 2025 •
edited
Loading

My custom rules project (io.nlopez.compose.rules:ktlint) hasn't been updated yet to use kotlin 2.2 / latest versions of ktlint. You could use the snapshots of the latest version for now if you wanted to keep this one, or force an earlier ktlint version in the config, or go with a different project that's updated. Sorry about that (indirectly haha)

@Goooler
Copy link
Member Author

Goooler commented Jul 17, 2025

Good to know! I guessed this is related to pinterest/ktlint#3061.

@Goooler Goooler marked this pull request as draft July 21, 2025 00:38
@Goooler Goooler force-pushed the g/20250715/ktlint branch from 17b151f to 816f879 Compare July 22, 2025 01:57
@Goooler Goooler changed the title Bump Ktlint to 1.7.0 Bump Ktlint to 1.7.1 Jul 22, 2025
@Goooler Goooler force-pushed the g/20250715/ktlint branch from 57eb676 to af022dc Compare July 22, 2025 02:17
@Goooler Goooler marked this pull request as ready for review July 22, 2025 02:48
@Goooler Goooler merged commit 1116e3b into main Jul 22, 2025
34 checks passed
@Goooler Goooler deleted the g/20250715/ktlint branch July 22, 2025 02:49
@Goooler Goooler mentioned this pull request Jul 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Goooler @nedtwigg @mrmans0n