Merged
Conversation
blakeli0
commented
Oct 11, 2024
suztomo
reviewed
Oct 11, 2024
Member
|
As per the document, we don't automatically bump the protobuf version. Can you disable RenovateBot for Protobuf? |
Contributor
Author
It will be included in follow up PRs, updated the description for this question. |
zhumin8
reviewed
Oct 14, 2024
zhumin8
approved these changes
Oct 14, 2024
Contributor
zhumin8
left a comment
There was a problem hiding this comment.
Left few comments that can be addressed in followup prs.
Co-authored-by: Min Zhu <zhumin@google.com>
suztomo
approved these changes
Oct 14, 2024
Member
suztomo
left a comment
There was a problem hiding this comment.
The discussion about the profiles are a minor item compared to seeing the result of testing.
JoeWang1127
approved these changes
Oct 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new bom
libraries-bom-protobuf3. This new bom includes identical client libraries aslibraries-bom, the only difference is thatlibraries-bom-protobuf3includesprotobuf-java3.x runtime version, whilelibraries-bomincludesprotobuf-java4.x runtime version. This is a workaround in case customers run into compatibility issues withprotobuf-java4.x runtime version.This bom will be tested with
0.1.0version in this release cycle, once we verify that the new bom is working as we expected, we would release it with a stable version that is identical tolibraries-bom. There will also be a follow up PRs that disable renovate bots for protobuf-bom, and update the automations to include the changes in release notes. See internal doc for details.