feat: introduce java.time variables and methods#1935
Merged
diegomarquezp merged 5 commits intomainfrom Nov 21, 2024
Merged
Conversation
lqiu96
reviewed
Nov 20, 2024
| // expressed as fractional | ||
| // seconds. | ||
| String durationString(org.threeten.bp.Duration duration) { | ||
| String durationStringDuration(java.time.Duration duration) { |
Member
There was a problem hiding this comment.
This is package-private. I think we can straight replace
Contributor
Author
There was a problem hiding this comment.
Good catch. Overload removed
lqiu96
reviewed
Nov 21, 2024
Comment on lines
+511
to
+513
| @Override | ||
| public java.time.Duration getTotalRequestTimeoutDuration() { | ||
| return firestoreOptions.getRetrySettings().getTotalTimeoutDuration(); |
Member
There was a problem hiding this comment.
nit: Would be nice to get javadocs from firestore for this
Contributor
Author
There was a problem hiding this comment.
@ehsannas for visibility - the superclass does not have javadocs on this method
lqiu96
approved these changes
Nov 21, 2024
Member
lqiu96
left a comment
There was a problem hiding this comment.
LGTM. Firestore team for final review
ehsannas
approved these changes
Nov 21, 2024
This was referenced Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
java.timealternatives to existingorg.threeten.bp.*methods, as well as switching internal variables (if any) tojava.timeThe main constraint is to keep the changes backwards compatible, so for each existing threeten method "
method1(org.threeten.bp.Duration)" we will add an alternative with a Duration (or Timestamp when applicable) suffix: "method1Duration(java.time.Duration)".For most cases, the implementation will be held in the
java.timemethod and the old threeten method will just delegate the call to it. However, for the case of abstract classes, the implementation will be kept in the threeten method to avoid breaking changes (i.e. users that already overloaded the method in their user code).