Improve JUnit Vintage docs about parallel execution#4336
Improve JUnit Vintage docs about parallel execution#4336marcphilipp merged 5 commits intojunit-team:mainfrom
Conversation
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
YongGoose
left a comment
There was a problem hiding this comment.
It would be great to add documentation for the following cases as well.
The document looks much better now.
Thank you! 🙂
junit.vintage.execution.parallel.enabled=false
junit.vintage.execution.parallel.classes=true
junit.vintage.execution.parallel.methods=true
@YongGoose - thanks for the feedback. I have updated the PR now addressing the comments. I have added the example above as well as the case where parallel execution is enabled but no parallel execution level is defined - to highlight this misconfiguration as well. Let me know what you think:) |
0efba29 to
c6831bb
Compare
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
c6831bb to
3432f69
Compare
LGTM 👍 |
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
3432f69 to
f71f8a5
Compare
Issue: junit-team#4321
f71f8a5 to
73f59f4
Compare
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
Actually, explaining the pool size together was my own idea, as mentioned in the comment below. 😅 @etrandafir93 I apologize for any confusion it may have caused. |
Issue: junit-team#4321
@YongGoose No worries, it was a good discussion 👍 Also, I've noticed that the pool-size parameter is used internally to define the executor's parallelism level, which is slightly different. I've added a short sentence about this. @marcphilipp thanks for the feedback, I have applied your suggestions now, let me know what you think. |
documentation/src/docs/asciidoc/user-guide/migration-from-junit4.adoc
Outdated
Show resolved
Hide resolved
|
@etrandafir93 Thank you! 👍 |
Issue: #4321
Overview
Improving user guide section about parallel test execution at class/methods level with JUnit Vintage.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations