Merged
Conversation
Member
alexfauquette
commented
Sep 3, 2024
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewhttps://deploy-preview-43585--material-ui.netlify.app/ Bundle size reportBundle size will be reported once CircleCI build #743908 finishes. |
mnajdova
reviewed
Sep 3, 2024
| { | ||
| text: 'v6 (next)', | ||
| href: `https://next.mui.com${languagePrefix}/material-ui/getting-started/`, | ||
| text: 'v6', |
Member
There was a problem hiding this comment.
This change makes sense 👍 What's with the other changes?
Member
Author
There was a problem hiding this comment.
.gitignore issues between master and v5. Should be fixed now :)
Member
Author
There was a problem hiding this comment.
@mnajdova I've added this modification to the release guide. I'm not sure it's the correct place https://www.notion.so/Core-Major-version-release-process-7601e24709b84d5fa43f20a13f7526c6?d=aa09017c89e1465db3e8782016d6b4ce&pvs=4#b0ab2c1f7455400884ef5893abe6caee
Member
There was a problem hiding this comment.
Thanks! Yep, that's the right place.
dbc9ebd to
8884e26
Compare
mnajdova
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.