change polling interval property name to match spec#6672
Merged
jack-berg merged 4 commits intoopen-telemetry:mainfrom Sep 4, 2024
Merged
change polling interval property name to match spec#6672jack-berg merged 4 commits intoopen-telemetry:mainfrom
jack-berg merged 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6672 +/- ##
============================================
- Coverage 89.98% 89.97% -0.01%
- Complexity 6314 6316 +2
============================================
Files 703 703
Lines 19062 19068 +6
Branches 1875 1877 +2
============================================
+ Hits 17152 17156 +4
- Misses 1333 1334 +1
- Partials 577 578 +1 ☔ View full report in Codecov by Sentry. |
jack-berg
reviewed
Aug 26, 2024
...in/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSamplerProvider.java
Show resolved
Hide resolved
jack-berg
approved these changes
Sep 4, 2024
…y-java into polling-interval-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the name of polling interval property used by the
jaeger_remoteandparentbased_jaeger_remotesamplers to align with the spec.I originally updated the docs (open-telemetry/opentelemetry.io#5100) to reflect the current behavior of Java SDK, but that was not the right choice -- we should fix it here instead.
Other implementations seem to be aligned with the current spec. For example:
Related: