Add Marshalers for profiling signal type#6680
Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom Sep 20, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6680 +/- ##
=========================================
Coverage 90.05% 90.05%
Complexity 6457 6457
=========================================
Files 718 718
Lines 19511 19511
Branches 1922 1922
=========================================
Hits 17571 17571
Misses 1350 1350
Partials 590 590 ☔ View full report in Codecov by Sentry. |
jack-berg
approved these changes
Sep 18, 2024
Member
jack-berg
left a comment
There was a problem hiding this comment.
Couple of nits, but looks good. Will merge after hearing back from you. Thanks!
...main/java/io/opentelemetry/exporter/otlp/profiles/InstrumentationScopeProfilesMarshaler.java
Outdated
Show resolved
Hide resolved
...rofiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/ResourceProfilesMarshaler.java
Outdated
Show resolved
Hide resolved
...profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/ProfilesRequestMarshaler.java
Outdated
Show resolved
Hide resolved
Envelope Marshalers, draft.
Changes addressing review comments
9259ee9 to
66bcc92
Compare
Contributor
Author
|
Thanks for the review. All changes done, along with the knock-on InstrumentationScopeProfilesMarshaler array->List modification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second instalment of the OTLP marshaling code for the profiling signal. Following on from #6565 which had the 'payload' data types (pprofextended.proto), this one has the 'envelope' types (profiles.proto).
Little of particular interest here, it's largely boilerplate.
There is an outstanding task to look at how the ByteBuffer type field is handled - it's the first usage in any signal type and the marshaling utility code doesn't have support for it, so for now it's just converted to byte[]. Adding the utility code will require some design discussion that feels better suited to factoring out into a separate PR, but I'd like to get this one in meanwhile as it's usefully functional even without that optimization.