Add helper class to capture context using ScheduledExecutorService#6712
Merged
jack-berg merged 12 commits intoopen-telemetry:mainfrom Oct 7, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6712 +/- ##
============================================
- Coverage 90.09% 90.01% -0.08%
- Complexity 6390 6482 +92
============================================
Files 711 719 +8
Lines 19333 19585 +252
Branches 1891 1931 +40
============================================
+ Hits 17418 17630 +212
- Misses 1335 1355 +20
- Partials 580 600 +20 ☔ View full report in Codecov by Sentry. |
jkwatson
reviewed
Sep 12, 2024
Contributor
jkwatson
left a comment
There was a problem hiding this comment.
This is a good idea. This PR needs some more testing, as there are bunch of uncovered methods in the implementation.
Signed-off-by: Adriano Machado <60320+ammachado@users.noreply.github.com>
b6c022c to
e5d7cc4
Compare
jack-berg
reviewed
Sep 18, 2024
jack-berg
reviewed
Sep 18, 2024
context/src/main/java/io/opentelemetry/context/CurrentContextScheduledExecutorService.java
Outdated
Show resolved
Hide resolved
jack-berg
reviewed
Sep 18, 2024
context/src/main/java/io/opentelemetry/context/ForwardingScheduledExecutorService.java
Outdated
Show resolved
Hide resolved
4 tasks
shalk
reviewed
Sep 30, 2024
Comment on lines
+16
to
+21
| private final ScheduledExecutorService delegate; | ||
|
|
||
| CurrentContextScheduledExecutorService(ScheduledExecutorService delegate) { | ||
| super(delegate); | ||
| this.delegate = delegate; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| private final ScheduledExecutorService delegate; | |
| CurrentContextScheduledExecutorService(ScheduledExecutorService delegate) { | |
| super(delegate); | |
| this.delegate = delegate; | |
| } | |
| CurrentContextScheduledExecutorService(ScheduledExecutorService delegate) { | |
| super(delegate); | |
| } |
|
|
||
| @Override | ||
| public ScheduledFuture<?> schedule(Runnable command, long delay, TimeUnit unit) { | ||
| return delegate.schedule(Context.current().wrap(command), delay, unit); |
Contributor
There was a problem hiding this comment.
Suggested change
| return delegate.schedule(Context.current().wrap(command), delay, unit); | |
| return ((ScheduledExecutorService) delegate()) | |
| .schedule(Context.current().wrap(command), delay, unit); |
Contributor
There was a problem hiding this comment.
I think I prefer just keeping a local copy of the delegate rather than having to make this cast everywhere.
|
|
||
| @Override | ||
| public <V> ScheduledFuture<V> schedule(Callable<V> callable, long delay, TimeUnit unit) { | ||
| return delegate.schedule(Context.current().wrap(callable), delay, unit); |
Contributor
There was a problem hiding this comment.
Suggested change
| return delegate.schedule(Context.current().wrap(callable), delay, unit); | |
| return ((ScheduledExecutorService) delegate()) | |
| .schedule(Context.current().wrap(callable), delay, unit); |
| @Override | ||
| public ScheduledFuture<?> scheduleAtFixedRate( | ||
| Runnable command, long initialDelay, long period, TimeUnit unit) { | ||
| return delegate.scheduleAtFixedRate(command, initialDelay, period, unit); |
Contributor
There was a problem hiding this comment.
Suggested change
| return delegate.scheduleAtFixedRate(command, initialDelay, period, unit); | |
| return ((ScheduledExecutorService) delegate()) | |
| .scheduleAtFixedRate(command, initialDelay, period, unit); |
| @Override | ||
| public ScheduledFuture<?> scheduleWithFixedDelay( | ||
| Runnable command, long initialDelay, long delay, TimeUnit unit) { | ||
| return delegate.scheduleWithFixedDelay(command, initialDelay, delay, unit); |
Contributor
There was a problem hiding this comment.
Suggested change
| return delegate.scheduleWithFixedDelay(command, initialDelay, delay, unit); | |
| return ((ScheduledExecutorService) delegate()) | |
| .scheduleWithFixedDelay(command, initialDelay, delay, unit); |
jack-berg
approved these changes
Oct 1, 2024
trask
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.