Use autoconfigured ClassLoader to load declarative config #6725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6725 +/- ##
=========================================
Coverage 90.06% 90.06%
- Complexity 6457 6463 +6
=========================================
Files 718 718
Lines 19511 19528 +17
Branches 1922 1923 +1
=========================================
+ Hits 17572 17588 +16
Misses 1350 1350
- Partials 589 590 +1 ☔ View full report in Codecov by Sentry. |
jack-berg
commented
Sep 16, 2024
...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfiguration.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Sep 16, 2024
...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfiguration.java
Show resolved
Hide resolved
…y-java into declarative-config-agent-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agent extensions aren't currently able to provide declarative configuration
ComponentProviderSPI implementations because the agent requires a them to be loaded using a particular class loader.This adds a new
FileConfiguration#createoverload which allowsSpiHelper(which is based on aClassLoader) to be specified, and updatesAutoConfiguredOpenTelemetrySdkBuilderto call this new method.