Don't require empty objects when referencing custom components#6891
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Nov 18, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6891 +/- ##
============================================
- Coverage 90.29% 90.28% -0.01%
- Complexity 6588 6589 +1
============================================
Files 729 729
Lines 19767 19769 +2
Branches 1944 1945 +1
============================================
+ Hits 17848 17849 +1
Misses 1327 1327
- Partials 592 593 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
breedx-splk
approved these changes
Nov 18, 2024
Contributor
breedx-splk
left a comment
There was a problem hiding this comment.
Killer. Love for the users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when referencing a custom processor, exporter, sampler, etc, you need to specify an empty object as config (i.e.
{}).This is a bug.
This PR fixes the bug.