web-api(fix): revert use of export type * to maintain backwards compatibility with TS 4.7#1841
Merged
web-api(fix): revert use of export type * to maintain backwards compatibility with TS 4.7#1841
export type * to maintain backwards compatibility with TS 4.7#1841Conversation
…patibility with, at least, TypeScript 4.7. Also add an "integration test" to ensure integrating web-api in a project with TS 4.7.2 works.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1841 +/- ##
=======================================
Coverage 81.85% 81.85%
=======================================
Files 35 35
Lines 7781 7781
Branches 318 318
=======================================
Hits 6369 6369
Misses 1400 1400
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add an "integration test" to ensure integrating web-api in a project with TS 4.7.2 works.
This fixes #1840.
FYI @742617000027