Adding MinIO module#7440
Merged
Merged
Conversation
eddumelendez
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution. We will talk about the module tomorrow. I just left some suggestions for general review. No changes should be applied until further notice.
Member
|
@frozenwizard Please, proceed making the changes. We discussed this Today and we will be hosting the module. Thanks again! |
Member
|
@frozenwizard I forgot to ask but can you some docs, please? |
eddumelendez
reviewed
Sep 4, 2023
eddumelendez
left a comment
Member
There was a problem hiding this comment.
Add additional test switching another credentials and verify those were set in the container
Comment on lines
+20
to
+44
| MinIOContainer container = new MinIOContainer("minio/minio:latest"); | ||
| container.start(); | ||
|
|
||
| MinioClient minioClient = MinioClient | ||
| .builder() | ||
| .endpoint(container.getS3URL()) | ||
| .credentials(container.getUserName(), container.getPassword()) | ||
| .build(); | ||
|
|
||
| minioClient.makeBucket(MakeBucketArgs.builder().bucket("test-bucket").region("us-west-2").build()); | ||
|
|
||
| BucketExistsArgs existsArgs = BucketExistsArgs.builder().bucket("test-bucket").build(); | ||
|
|
||
| assertThat(minioClient.bucketExists(existsArgs)).isTrue(); | ||
|
|
||
| URL file = this.getClass().getResource("/object_to_upload.txt"); | ||
| assertThat(file).isNotNull(); | ||
| ObjectWriteResponse upload = minioClient.uploadObject( | ||
| UploadObjectArgs.builder().bucket("test-bucket").object("my-objectname").filename(file.getPath()).build() | ||
| ); | ||
|
|
||
| StatObjectResponse objectStat = minioClient.statObject( | ||
| StatObjectArgs.builder().bucket("test-bucket").object("my-objectname").build() | ||
| ); | ||
|
|
||
| assertThat(objectStat.object()).isEqualTo("my-objectname"); |
Member
There was a problem hiding this comment.
replace latest with a specific version
Suggested change
| MinIOContainer container = new MinIOContainer("minio/minio:latest"); | |
| container.start(); | |
| MinioClient minioClient = MinioClient | |
| .builder() | |
| .endpoint(container.getS3URL()) | |
| .credentials(container.getUserName(), container.getPassword()) | |
| .build(); | |
| minioClient.makeBucket(MakeBucketArgs.builder().bucket("test-bucket").region("us-west-2").build()); | |
| BucketExistsArgs existsArgs = BucketExistsArgs.builder().bucket("test-bucket").build(); | |
| assertThat(minioClient.bucketExists(existsArgs)).isTrue(); | |
| URL file = this.getClass().getResource("/object_to_upload.txt"); | |
| assertThat(file).isNotNull(); | |
| ObjectWriteResponse upload = minioClient.uploadObject( | |
| UploadObjectArgs.builder().bucket("test-bucket").object("my-objectname").filename(file.getPath()).build() | |
| ); | |
| StatObjectResponse objectStat = minioClient.statObject( | |
| StatObjectArgs.builder().bucket("test-bucket").object("my-objectname").build() | |
| ); | |
| assertThat(objectStat.object()).isEqualTo("my-objectname"); | |
| try(MinIOContainer container = new MinIOContainer("minio/minio:latest")) { | |
| container.start(); | |
| MinioClient minioClient = MinioClient | |
| .builder() | |
| .endpoint(container.getS3URL()) | |
| .credentials(container.getUserName(), container.getPassword()) | |
| .build(); | |
| minioClient.makeBucket(MakeBucketArgs.builder().bucket("test-bucket").region("us-west-2").build()); | |
| BucketExistsArgs existsArgs = BucketExistsArgs.builder().bucket("test-bucket").build(); | |
| assertThat(minioClient.bucketExists(existsArgs)).isTrue(); | |
| URL file = this.getClass().getResource("/object_to_upload.txt"); | |
| assertThat(file).isNotNull(); | |
| ObjectWriteResponse upload = minioClient.uploadObject( | |
| UploadObjectArgs.builder().bucket("test-bucket").object("my-objectname").filename(file.getPath()).build() | |
| ); | |
| StatObjectResponse objectStat = minioClient.statObject( | |
| StatObjectArgs.builder().bucket("test-bucket").object("my-objectname").build() | |
| ); | |
| assertThat(objectStat.object()).isEqualTo("my-objectname"); | |
| } |
| * <p> | ||
| * Exposed ports: 9000,9001 | ||
| */ | ||
| @Slf4j |
| * Constructs a MinIO container from the dockerImageName | ||
| * @param dockerImageName the full image name to use | ||
| */ | ||
| public MinIOContainer(@NonNull final String dockerImageName) { |
Member
There was a problem hiding this comment.
Suggested change
| public MinIOContainer(@NonNull final String dockerImageName) { | |
| public MinIOContainer(final String dockerImageName) { |
eddumelendez
reviewed
Sep 4, 2023
|
|
||
| URL file = this.getClass().getResource("/object_to_upload.txt"); | ||
| assertThat(file).isNotNull(); | ||
| ObjectWriteResponse upload = minioClient.uploadObject( |
Contributor
Author
There was a problem hiding this comment.
In general if an upload fails it throws an exception. If we get the upload object back then it was a success. I can make it more clear with a comment or remove the variable.
Member
There was a problem hiding this comment.
removing the variable would be fine
Contributor
Author
Sure where would they go? |
Member
|
docs can be added here and then update the mkdocs.yml in the root directory |
eddumelendez
reviewed
Sep 5, 2023
eddumelendez
reviewed
Sep 6, 2023
eddumelendez
approved these changes
Sep 6, 2023
Member
|
Thanks for your contribution, @frozenwizard ! I've made some changes to keep aligned with the image. Module will be release as part of the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the MinIO container.