feat(eslint-plugin): [max-params] add function overload and function type support by developer-bandi · Pull Request #10312 · typescript-eslint/typescript-eslint

developer-bandi · 2024-11-09T10:32:51Z

PR Checklist

Addresses an existing open issue: fixes Enhancement: [max-params] add option to check overload signatures as well #10293
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Added support for the TSDeclareFunction and TSFunctionType types.

typescript-eslint · 2024-11-09T10:32:55Z

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-11-09T10:33:08Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`b22fbbd`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6740db3de7dc860008a5a313
😎 Deploy Preview	https://deploy-preview-10312--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-11-09T10:33:44Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b22fbbd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg

Good start 🚀

codecov · 2024-11-10T23:17:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (90aa814) to head (4d7cf19).
Report is 3 commits behind head on main.

❗ Current head 4d7cf19 differs from pull request most recent head b22fbbd

Please upload reports for the commit b22fbbd to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10312      +/-   ##
==========================================
- Coverage   86.69%   86.57%   -0.12%     
==========================================
  Files         434      431       -3     
  Lines       15227    15198      -29     
  Branches     4445     4421      -24     
==========================================
- Hits        13201    13158      -43     
- Misses       1670     1683      +13     
- Partials      356      357       +1

Flag	Coverage Δ
unittest	`86.57% <ø> (-0.12%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/max-params.ts	`94.44% <ø> (ø)`

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

JoshuaKGoldberg

🙌 looks great to me, thanks as always @developer-bandi!

@developer-bandi

##### [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287)) - **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@developer-bandi

##### [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287)) - **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@developer-bandi

##### [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287)) - **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@developer-bandi

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.15.0 | 8.16.0 | | npm | @typescript-eslint/parser | 8.15.0 | 8.16.0 | ## [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287)) - **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

feat: add function overload support

52b424a

developer-bandi marked this pull request as draft November 9, 2024 10:51

fix: type error

8556e91

developer-bandi changed the title ~~feat(eslint-plugin): [max-params]: add function overload and function type support~~ feat(eslint-plugin): [max-params] add function overload and function type support Nov 9, 2024

developer-bandi marked this pull request as ready for review November 9, 2024 11:47

injae-kim mentioned this pull request Nov 10, 2024

Enhancement: [max-params] add option to check overload signatures as well #10293

Closed

4 tasks

JoshuaKGoldberg requested changes Nov 10, 2024

View reviewed changes

Comment thread packages/eslint-plugin/tests/rules/max-params.test.ts

Comment thread packages/eslint-plugin/tests/rules/max-params.test.ts Outdated

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 10, 2024

test: add valid test case

4d7cf19

developer-bandi requested a review from JoshuaKGoldberg November 10, 2024 23:01

github-actions Bot removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 10, 2024

JoshuaKGoldberg approved these changes Nov 22, 2024

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 22, 2024

Merge branch 'main' into feat/max-params

b22fbbd

kirkwaiblinger approved these changes Nov 22, 2024

View reviewed changes

JoshuaKGoldberg merged commit cdbc669 into typescript-eslint:main Nov 22, 2024

github-actions Bot locked as resolved and limited conversation to collaborators Nov 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(eslint-plugin): [max-params] add function overload and function type support#10312

feat(eslint-plugin): [max-params] add function overload and function type support#10312
JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfrom
developer-bandi:feat/max-params

developer-bandi commented Nov 9, 2024

Uh oh!

typescript-eslint Bot commented Nov 9, 2024

Uh oh!

netlify Bot commented Nov 9, 2024 •

edited

Loading

Uh oh!

nx-cloud Bot commented Nov 9, 2024 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Nov 10, 2024 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

developer-bandi commented Nov 9, 2024

PR Checklist

Overview

Uh oh!

typescript-eslint Bot commented Nov 9, 2024

Uh oh!

netlify Bot commented Nov 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud Bot commented Nov 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Nov 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Nov 9, 2024 •

edited

Loading

nx-cloud Bot commented Nov 9, 2024 •

edited

Loading

codecov Bot commented Nov 10, 2024 •

edited

Loading