fix(plugin-vue): treat it as a client build when calling from Rstest #6779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the configuration required for rstest users by automatically detecting when the plugin is called from rstest and setting isServerBuild: false by default, since rstest always runs tests in a DOM environment.
Key Changes:
- Automatically sets
isServerBuild: falsein vue-loader options whencallerName === 'rstest' - Removes the manual
isServerBuildconfiguration from rstest template files
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/plugin-vue/src/index.ts |
Adds logic to detect rstest caller and automatically set isServerBuild: false |
packages/create-rsbuild/template-rstest/vue-ts/rstest.config.ts |
Simplifies configuration by removing manual isServerBuild setting |
packages/create-rsbuild/template-rstest/vue-js/rstest.config.js |
Simplifies configuration by removing manual isServerBuild setting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
chenjiahan
reviewed
Dec 15, 2025
chenjiahan
approved these changes
Dec 15, 2025
This was referenced Dec 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(plugin-vue): treat it as a client build when calling from rstest, since it always test in dom environment.
reduce
isServerBuildconfiguration in user config file.Related Links
Checklist