feat: update node builtins set for hints #6783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Node.js built-in modules detection in the error hint system to improve module resolution error messages. The changes enhance both the completeness of recognized modules and the lookup performance.
Key changes:
- Added 8 missing Node.js built-in modules (diagnostics_channel, http2, inspector, perf_hooks, trace_events, v8, wasi, worker_threads)
- Improved lookup performance by converting from Array with
.includes()to Set with.has() - Reorganized internal stream aliases with clarifying comments and better code structure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated and expanded the list of recognized built-in modules: added missing modules like
diagnostics_channel,http2,inspector,perf_hooks,trace_events,v8,wasi, andworker_threads.Checklist