test: fix initial chunks HMR test case #6864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the initial chunks HMR test case by switching from dev.lazyCompilation to tools.rspack.lazyCompilation, which resolves an issue where lazy compilation doesn't work with single entry configurations.
- Migrated lazy compilation configuration from
dev.lazyCompilationtotools.rspack.lazyCompilation - Removed unnecessary core-js dependencies and polyfill configuration to simplify the test
- Updated the configuration structure from function-based to object-based for
tools.rspack
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/cases/lazy-compilation/add-initial-chunk/rsbuild.config.ts | Migrated lazy compilation config to tools.rspack.lazyCompilation, removed polyfill configuration, simplified cache group test regex |
| e2e/cases/lazy-compilation/add-initial-chunk/src/index.js | Removed core-js import no longer needed after removing polyfill configuration |
| e2e/cases/lazy-compilation/add-initial-chunk/src/initial.js | Removed core-js/package.json import no longer needed for test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the initial chunks HMR test case.
dev.lazyCompilationdoes not work when there is only one entry, usetools.rspack.lazyCompilationinstead.Related Links
Checklist