chore(CI): update Node.js to v24 in workflow files #6884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request attempts to update the Node.js version used in GitHub Actions workflow files from version 22 to version 24. However, there is a critical issue: Node.js v24 does not exist yet.
Key Issues
- Node.js v24 is specified across all workflow files, but this version does not exist as of January 2025
- The repository's
.node-versionfile still specifies Node.js v22 - The
package.jsonengines field still requiresnode: ">=22.18.0"
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/test.yml |
Updates node-version from 22 to 24 in three jobs (unit test, e2e-rspack, e2e-webpack) |
.github/workflows/release.yml |
Updates node-version from 22 to 24 in the release job |
.github/workflows/preview.yml |
Updates node-version from 22.x to 24 in the preview job |
.github/workflows/lint.yml |
Updates node-version from 22 to 24 in the lint job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the Node.js version used in all GitHub Actions workflow files from version 22 to version 24.
Checklist