fix(theme/nav): Fixed small layout shift on scroll#2980
Merged
SoonIter merged 1 commit intoweb-infra-dev:mainfrom Jan 9, 2026
Merged
fix(theme/nav): Fixed small layout shift on scroll#2980SoonIter merged 1 commit intoweb-infra-dev:mainfrom
SoonIter merged 1 commit intoweb-infra-dev:mainfrom
Conversation
When scrolling: as the nav bar transitions to having a bottom border and a blurred background, the layout of the icons would shift up slightly due to the bottom border size changing. To fix this I've made it so that the bottom border is always 1px but is transparent by default. This prevents the layout shift when scrolling.
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a minor layout shift issue that occurs when scrolling causes the navigation bar to transition from transparent to having a visible bottom border. The fix ensures the border remains 1px at all times, only changing from transparent to visible, which prevents the navigation icons from shifting vertically during scroll.
Key changes:
- Modified the CSS rule for the navigation bar to maintain a constant 1px transparent border instead of no border when at the top of the page
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When scrolling: as the nav bar transitions to having a bottom border and a blurred background, the layout of the icons would shift up slightly due to the bottom border size changing. To fix this I've made it so that the bottom border is always 1px but is transparent by default. This prevents the layout shift when scrolling.
Super tiny PR but spotted this while experimenting with the latest release candidate.
Before
stylebug-2026-01-08_20.08.19.mp4
After
stylebug-fixed-2026-01-08_20.10.10.mp4
Related Issue
N/A
Checklist