fix: should print error correctly when worker unexpectedly exit #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes error reporting when worker setup fails by adding global process event handlers and conditionally excluding Node.js-specific flags when running in Deno.
- Adds global
uncaughtExceptionandunhandledRejectionevent handlers to catch worker setup errors - Introduces
isDenodetection to conditionally exclude Node.js-specific flags from workerexecArgv - Extracts error handling logic into a reusable
handleUnexpectedExitfunction
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/utils/helper.ts | Adds isDeno constant to detect Deno runtime |
| packages/core/src/pool/index.ts | Conditionally excludes Node.js experimental flags when running in Deno |
| packages/core/src/cli/commands.ts | Adds global process error handlers and extracts handleUnexpectedExit helper function |
| e2e/cli/fixtures/worker.error.config.ts | Adds test fixture config with invalid worker flag to test error handling |
| e2e/cli/config.test.ts | Adds test case to verify worker setup errors are printed correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Links
#828
Checklist