add option to do a Jetty server dump to help with debug (jetty9)#102
Merged
copybara-service[bot] merged 3 commits intomainfrom Apr 23, 2024
Merged
add option to do a Jetty server dump to help with debug (jetty9)#102copybara-service[bot] merged 3 commits intomainfrom
copybara-service[bot] merged 3 commits intomainfrom
Conversation
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Collaborator
Author
|
The output of this only includes a very basic dump of the |
Contributor
|
@lachlan-roberts can you include a comment with an example of the dump as it currently is... we can then look at AppVersionHandlerMap to see how we can improve its dumpability (and general containment tree). |
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
Apr 23, 2024
Contributor
gregw
left a comment
There was a problem hiding this comment.
It is kind of strange the context is started before we add it... but hey, it works
ludoch
approved these changes
Apr 23, 2024
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
PiperOrigin-RevId: 627463828 Change-Id: If7aeed512156a5cab5110ad568587d2136b5bff9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builds upon the work from PR #101
Now the Jetty Server dump displays correctly for all runtimes.
In Jetty 12 runtimes we no longer manually start the context, it is started when it is added to the
HotSwapHandler.In Jetty 9.4 runtimes we now add the context as a managed bean onto the
AppVersionHandlerMapso it is correctly displayed in the dump.