use startWebapp instead of doStart for AppEngineWebAppContext#115
Merged
use startWebapp instead of doStart for AppEngineWebAppContext#115
Conversation
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
ludoch
approved these changes
Apr 30, 2024
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
…xt-startWebapp PiperOrigin-RevId: 629254889 Change-Id: Icad130ead65d0e9f54f7adf93a6c82e6a55c8225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit should have been included with #105 but for some reason was not there. Maybe I forgot to push it.
This
startWebappmethod was previously missing but re-introduced in Jetty12.0.8.