fix: remove erroneous check for the subject token field name for text credential source#822
Merged
lsirac merged 4 commits intogoogleapis:mainfrom Jan 10, 2022
lsirac:wif_bugfix
Merged
fix: remove erroneous check for the subject token field name for text credential source#822lsirac merged 4 commits intogoogleapis:mainfrom lsirac:wif_bugfix
lsirac merged 4 commits intogoogleapis:mainfrom
lsirac:wif_bugfix
Conversation
… format in IdentityPoolCredentialSource
TimurSadykov
reviewed
Jan 7, 2022
oauth2_http/java/com/google/auth/oauth2/IdentityPoolCredentials.java
Outdated
Show resolved
Hide resolved
TimurSadykov
reviewed
Jan 7, 2022
oauth2_http/java/com/google/auth/oauth2/IdentityPoolCredentials.java
Outdated
Show resolved
Hide resolved
TimurSadykov
reviewed
Jan 7, 2022
oauth2_http/javatests/com/google/auth/oauth2/IdentityPoolCredentialsTest.java
Show resolved
Hide resolved
TimurSadykov
suggested changes
Jan 7, 2022
TimurSadykov
left a comment
There was a problem hiding this comment.
One small fix to make sure we support case insensitive headers
Neenu1995
approved these changes
Jan 7, 2022
TimurSadykov
reviewed
Jan 8, 2022
oauth2_http/javatests/com/google/auth/oauth2/IdentityPoolCredentialsTest.java
Outdated
Show resolved
Hide resolved
TimurSadykov
reviewed
Jan 8, 2022
oauth2_http/java/com/google/auth/oauth2/IdentityPoolCredentials.java
Outdated
Show resolved
Hide resolved
TimurSadykov
approved these changes
Jan 8, 2022
TimurSadykov
left a comment
There was a problem hiding this comment.
LGTM, but please remove "star" imports
TimurSadykov
pushed a commit
that referenced
this pull request
Jan 13, 2022
…r text credential source (#822) * fix: remove erroneous check for the subject token field name for text format in IdentityPoolCredentialSource * fix: case insensitive * fix: null check * fix: imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #815