Conversation
Now that protoc version is updated to 25.3 in [google3](https://critique.corp.google.com/cl/624989428), we need to update the `protobuf_version` in generation_config.yaml as well to keep it in sync. This is a temporary solution until all handwritten libraries are also migrated to hermetic build scripts. @JoeWang1127 Do you mind updating our release manager operation doc to include this step?
lqiu96
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that protoc version is updated to 25.3 in google3, we need to update the
protobuf_versioningeneration_config.yamlas well to keep it in sync.This is a temporary solution until all handwritten libraries are also migrated to hermetic build scripts. Once all Java repos are migrated to hermetic build scripts, we will be using the protoc version specified in
sdk-platform-java, not fromWORKSPACE.@JoeWang1127 Do you mind updating our release manager operation doc to include this step?