Skip to content

feat: [admanager] new module for admanager#10750

Merged
lqiu96 merged 2 commits intomainfrom
new-library/admanager-eIoMe
Apr 25, 2024
Merged

feat: [admanager] new module for admanager#10750
lqiu96 merged 2 commits intomainfrom
new-library/admanager-eIoMe

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Apr 25, 2024

Generated by @lqiu96 via generate_new_client_hermetic_build.yaml

Command used:

python generation/new_client_hermetic_build/add-new-client-config.py add-new-client --api-shortname "admanager" --name-pretty "Google Ad Manager API" --api-description "The Ad Manager API enables an app to integrate with Google Ad Manager. You can read Ad Manager data and run reports using the API." --proto-path "google/ads/admanager/v1" --product-docs "https://developers.google.com/ad-manager/api/beta" --distribution-name "com.google.api-ads:ad-manager"

docker run --rm \
  ${repo_volumes} \
  -v /tmp:/tmp \
  -v /var/run/docker.sock:/var/run/docker.sock \
  -e "RUNNING_IN_DOCKER=true" \
  -e "REPO_BINDING_VOLUMES=${repo_volumes}" \
  localowlbot:latest \
  python /src/generate_repo.py generate \
  --generation-config-yaml=/workspace/google-cloud-java/generation_config.yaml \
  --repository-path=/workspace/google-cloud-java \
  --target-library-names=admanager

Used a local library generation image to help with generating the proto directory

@lqiu96 lqiu96 requested review from a team and suztomo April 25, 2024 15:15
@snippet-bot
Copy link

snippet-bot bot commented Apr 25, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 212 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

suztomo
suztomo approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lqiu96 Are you merging this? We can rename the folder after the initial release, without changing Maven artifact coordinates.

@lqiu96
Copy link
Member Author

lqiu96 commented Apr 25, 2024

@lqiu96 Are you merging this? We can rename the folder after the initial release, without changing Maven artifact coordinates.

I'll do that in a separate PR if you're ok with it.

@lqiu96 lqiu96 merged commit afdbb64 into main Apr 25, 2024
@lqiu96 lqiu96 deleted the new-library/admanager-eIoMe branch April 25, 2024 17:54
@release-please release-please bot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lqiu96 @suztomo @cloud-java-bot