Skip to content

Regenerate firestore client#6210

Merged
chingor13 merged 1 commit intomasterfrom
autosynth-firestore
Sep 11, 2019
Merged

Regenerate firestore client#6210
chingor13 merged 1 commit intomasterfrom
autosynth-firestore

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Sep 4, 2019

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-firestore/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:0e6f3a668cd68afc768ecbe08817cf6e56a0e64fcbdb1c58c3b97492d12418a1
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/firestore/admin/artman_firestore_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 98 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 50 files
synthtool > Running generator for google/firestore/artman_firestore.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 98 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 87 files
synthtool > Running generator for google/firestore/artman_firestore_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 98 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 87 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 4, 2019
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2019
@codecov
Copy link

codecov bot commented Sep 4, 2019 •
edited
Loading

Codecov Report

Merging #6210 into master will decrease coverage by 0.36%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6210      +/-   ##
============================================
- Coverage     47.53%   47.17%   -0.37%     
+ Complexity    27472    26007    -1465     
============================================
  Files          2534     2534              
  Lines        274924   269646    -5278     
  Branches      31408    31208     -200     
============================================
- Hits         130681   127199    -3482     
+ Misses       134610   133748     -862     
+ Partials       9633     8699     -934
Impacted Files Coverage Δ Complexity Δ
...cloud/firestore/v1/stub/FirestoreStubSettings.java 79.26% <100%> (-0.38%) 22 <0> (-1)
.../firestore/v1/stub/FirestoreAdminStubSettings.java 80.55% <100%> (-0.32%) 18 <0> (-1)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
... and 642 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f6aac8...eee06fc. Read the comment docs.

@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2019
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2019
BenWhitehead
BenWhitehead reviewed Sep 11, 2019
View reviewed changes
Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me. @schmidt-sebastian Does this look okay to you?

schmidt-sebastian
schmidt-sebastian approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13 chingor13 merged commit f072412 into master Sep 11, 2019
@chingor13 chingor13 deleted the autosynth-firestore branch September 11, 2019 17:23
@kolea2 kolea2 mentioned this pull request Sep 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@BenWhitehead BenWhitehead BenWhitehead left review comments

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yoshi-automation @BenWhitehead @schmidt-sebastian @chingor13 @googlebot @yoshi-kokoro @kolea2