Skip to content

Commit 19d92a1

Browse files
PhongChuonggcf-owl-bot[bot]
PhongChuong
and
gcf-owl-bot[bot]
authored
fix: Remove @internalapi from TableResult (#3257)
* fix: Remove @internalapi from TableResult Since users depends on TableResult in testing, removing @internalapi forces maintainers to change/roll out changes to TableResult more carefully in the future. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Remove clirr ignore difference entries for TableResult --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 6df3a32 commit 19d92a1

File tree

2 files changed

+0
-40
lines changed

2 files changed

+0
-40
lines changed

‎google-cloud-bigquery/clirr-ignored-differences.xml‎

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,6 @@
22
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
33
<differences>
44
<!-- TODO: REMOVE AFTER RELEASE -->
5-
<difference>
6-
<differenceType>3005</differenceType>
7-
<className>com/google/cloud/bigquery/TableResult*</className>
8-
<justification>TableResult is an internal API and it should be fine to update</justification>
9-
</difference>
10-
<difference>
11-
<differenceType>7002</differenceType>
12-
<className>com/google/cloud/bigquery/TableResult*</className>
13-
<method>*TableResult(*)</method>
14-
<justification>TableResult is an internal API and it should be fine to update</justification>
15-
</difference>
165
<difference>
176
<differenceType>7004</differenceType>
187
<className>com/google/cloud/bigquery/spi/v2/BigQueryRpc</className>
@@ -25,19 +14,6 @@
2514
<method>com.google.api.services.bigquery.model.GetQueryResultsResponse getQueryResultsWithRowLimit(java.lang.String, java.lang.String, java.lang.String, java.lang.Integer)</method>
2615
<justification>getQueryResultsWithRowLimit is just used by ConnectionImpl at the moment so it should be fine to update the signature instead of writing an overloaded method</justification>
2716
</difference>
28-
<difference>
29-
<differenceType>7004</differenceType>
30-
<className>com/google/cloud/bigquery/TableResult*</className>
31-
<method>*TableResult(*)</method>
32-
<justification>It should be fine to update TableResult constructors since it is used to return results to the user and users should not directly construct TableResult objects</justification>
33-
</difference>
34-
<difference>
35-
<differenceType>7005</differenceType>
36-
<className>com/google/cloud/bigquery/TableResult*</className>
37-
<method>*TableResult(*)</method>
38-
<to>*TableResult(*)</to>
39-
<justification>It should be fine to update TableResult constructors since it is used to return results to the user and users should not directly construct TableResult objects</justification>
40-
</difference>
4117
<difference>
4218
<differenceType>7013</differenceType>
4319
<className>com/google/cloud/bigquery/ExternalTableDefinition*</className>
@@ -58,16 +34,6 @@
5834
<className>com/google/cloud/bigquery/TableInfo*</className>
5935
<method>*ResourceTags(*)</method>
6036
</difference>
61-
<difference>
62-
<differenceType>7013</differenceType>
63-
<className>com/google/cloud/bigquery/TableResult*</className>
64-
<method>*getPageNoSchema(*)</method>
65-
</difference>
66-
<difference>
67-
<differenceType>7013</differenceType>
68-
<className>com/google/cloud/bigquery/TableResult*</className>
69-
<method>*toBuilder(*)</method>
70-
</difference>
7137
<difference>
7238
<differenceType>7012</differenceType>
7339
<className>com/google/cloud/bigquery/Connection</className>
@@ -163,8 +129,4 @@
163129
<className>com/google/cloud/bigquery/StandardTableDefinition*</className>
164130
<method>*BigLakeConfiguration(*)</method>
165131
</difference>
166-
<difference>
167-
<differenceType>8001</differenceType>
168-
<className>com/google/cloud/bigquery/EmptyTableResult*</className>
169-
</difference>
170132
</differences>

‎google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.google.cloud.bigquery;
1818

19-
import com.google.api.core.InternalApi;
2019
import com.google.api.gax.paging.Page;
2120
import com.google.auto.value.AutoValue;
2221
import com.google.common.base.Function;
@@ -27,7 +26,6 @@
2726
import java.util.Objects;
2827
import javax.annotation.Nullable;
2928

30-
@InternalApi
3129
@AutoValue
3230
public abstract class TableResult implements Page<FieldValueList>, Serializable {
3331

0 commit comments

Comments
 (0)