fix: Socket-timeout at bigquery.it.ITNightlyBigQueryTest: testForTableNotFound#2260
Merged
prash-mi merged 2 commits intogoogleapis:mainfrom Sep 2, 2022
Merged
fix: Socket-timeout at bigquery.it.ITNightlyBigQueryTest: testForTableNotFound#2260prash-mi merged 2 commits intogoogleapis:mainfrom
prash-mi merged 2 commits intogoogleapis:mainfrom
Conversation
shollyman
approved these changes
Sep 1, 2022
Contributor
shollyman
left a comment
There was a problem hiding this comment.
Approving this, though I recommend consolidating the execution logic in another PR if you don't do it in this one.
| @@ -190,11 +190,13 @@ public BigQueryResult executeSelect(String sql) throws BigQuerySQLException { | |||
| try { | |||
Contributor
There was a problem hiding this comment.
May be better for another PR, but why is all this logic duplicated here, rather than just using a common executeSelect and not supplying the optional params/labels/etc?
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing Seth, I have captured refactoring this as a task @ #2240 point#3 . Will update you once we raise a PR.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
🤖 I have created a release *beep* *boop* --- ## [2.16.0](v2.15.0...v2.16.0) (2022-09-12) ### Features * Add preserveAsciiControlCharacters to CsvOptions ([#2143](#2143)) ([856893f](856893f)) * Add reference file schema option for federated formats ([#2269](#2269)) ([8c488e6](8c488e6)) ### Bug Fixes * Socket-timeout at bigquery.it.ITNightlyBigQueryTest: testForTableNotFound ([#2260](#2260)) ([a9b5fb2](a9b5fb2)) ### Dependencies * Update dependency com.google.apis:google-api-services-bigquery to v2-rev20220827-2.0.0 ([#2261](#2261)) ([3c67d21](3c67d21)) * Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.9.3 ([#2259](#2259)) ([5e30a04](5e30a04)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#2267](#2267)) ([8472fe5](8472fe5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaulted timeoutMs to 10s & Added additional logging
Fixes #2248 ☕️