Skip to content

feat: Allow passing autodetect_schema on table update#2661

Merged
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom
emkornfield:add_autodetect
May 5, 2023
Merged

feat: Allow passing autodetect_schema on table update#2661
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom
emkornfield:add_autodetect

Conversation

@emkornfield
Copy link
Contributor

@emkornfield emkornfield commented Apr 26, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Didn't open an issue because this seems trivial, happy to adapt if necessary.
  • [x ] Ensure the tests and linter pass (mvn test verify
  • [x ] Code coverage does not decrease (if any source code was changed)
  • [x ] Appropriate docs were updated (if necessary)

@emkornfield emkornfield requested a review from a team as a code owner April 26, 2023 23:16
@emkornfield emkornfield requested a review from alvarowolfx April 26, 2023 23:16
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Apr 26, 2023
@emkornfield
Copy link
Contributor Author

emkornfield commented Apr 26, 2023

@alvarowolfx seems like you might be a suggested reviewer here?

alvarowolfx
alvarowolfx approved these changes Apr 27, 2023
View reviewed changes
Copy link

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good on my end @emkornfield, but I'd ask @Neenu1995 for some Java specific review.

@alvarowolfx alvarowolfx requested a review from Neenu1995 April 27, 2023 15:36
@emkornfield
Copy link
Contributor Author

emkornfield commented Apr 27, 2023

@shollyman could you take a look in place of Neenu? This change is to help a customer resolve an issue they are seeing.

@shollyman shollyman added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 27, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team April 28, 2023 00:08
@Neenu1995
Copy link
Contributor

Neenu1995 commented May 1, 2023

Please also add IT tests to verify the functionality.

@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 1, 2023
@emkornfield
Copy link
Contributor Author

emkornfield commented May 1, 2023

Please also add IT tests to verify the functionality.

@Neenu1995 I don't appear to have access to the test buckets to verify a unit test. I can push what I think it likely a working unit test but would likely need your help to verify. Is there some other way I can formulate a unit test without access to the buckets?

@Neenu1995
Copy link
Contributor

Neenu1995 commented May 3, 2023

Hi @emkornfield,

Feel free to add the tests to the PR. We can help with the verification.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 3, 2023
@emkornfield
Copy link
Contributor Author

emkornfield commented May 3, 2023

@Neenu1995 added a first stab at an integration test.

@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2023
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2023
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2023
@Neenu1995
Copy link
Contributor

Neenu1995 commented May 3, 2023 

com.google.cloud.bigquery.BigQueryException: An internal error occurred and the request could not be completed. This is usually caused by a transient issue. Retrying the job with back-off as described in the BigQuery SLA should solve the problem: https://cloud.google.com/bigquery/sla. If the error continues to occur please contact support at https://cloud.google.com/support. Error: 8965006
	at com.google.cloud.bigquery.spi.v2.HttpBigQueryRpc.translate(HttpBigQueryRpc.java:115)
	at com.google.cloud.bigquery.spi.v2.HttpBigQueryRpc.patch(HttpBigQueryRpc.java:285)
	at com.google.cloud.bigquery.BigQueryImpl$15.call(BigQueryImpl.java:696)
	at com.google.cloud.bigquery.BigQueryImpl$15.call(BigQueryImpl.java:693)
	at com.google.api.gax.retrying.DirectRetryingExecutor.submit(DirectRetryingExecutor.java:103)
	at com.google.cloud.RetryHelper.run(RetryHelper.java:76)
	at com.google.cloud.RetryHelper.runWithRetries(RetryHelper.java:50)
	at com.google.cloud.bigquery.BigQueryImpl.update(BigQueryImpl.java:692)
	at com.google.cloud.bigquery.it.ITBigQueryTest.testUpdatePermExternableTableWithAutodetectSchemaUpdatesSchema(ITBigQueryTest.java:1593)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	```

@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2023
@Neenu1995
Copy link
Contributor

Neenu1995 commented May 4, 2023

Two test failing :

  • testUpdatePermExternableTableWithAutodetectSchemaUpdatesSchema - java.lang.AssertionError

  • testListTablesWithPartitioning - java.lang.ClassCastException: com.google.cloud.bigquery.AutoValue_ExternalTableDefinition cannot be cast to com.google.cloud.bigquery.StandardTableDefinition

@emkornfield
Copy link
Contributor Author

emkornfield commented May 5, 2023

@Neenu1995 got integration test work (at least kokoro seems happy).

@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 5, 2023
@Neenu1995
Copy link
Contributor

Neenu1995 commented May 5, 2023

Thanks @emkornfield. LGTM.

@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label May 5, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4c01698 into googleapis:main May 5, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 5, 2023
@release-please release-please bot mentioned this pull request May 5, 2023
Merged
This was referenced May 23, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

@alvarowolfx alvarowolfx alvarowolfx approved these changes

@Neenu1995 Neenu1995 Neenu1995 approved these changes

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emkornfield @Neenu1995 @shollyman @alvarowolfx @yoshi-kokoro