fix: Close based on whether connection is active, not status variable#1750
Merged
yirutang merged 1 commit intogoogleapis:mainfrom Aug 16, 2022
Merged
fix: Close based on whether connection is active, not status variable#1750yirutang merged 1 commit intogoogleapis:mainfrom
yirutang merged 1 commit intogoogleapis:mainfrom
Conversation
yirutang
approved these changes
Aug 16, 2022
| this.lock.lock(); | ||
| try { | ||
| if (connectionFinalStatus != null) { | ||
| if (!this.streamConnectionIsConnected) { |
Contributor
There was a problem hiding this comment.
I am wondering if there is a way to unit test this case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final status isn't set after retriable error, but if we're not connected, there's no point in waiting for a done callback.
Unit tests aren't set up for this, but verified by temporarily adding 10m wait to IT, which works after fix.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.