feat: expose settings to configure default missing value interpretation.#2230
Merged
yirutang merged 6 commits intogoogleapis:mainfrom Aug 17, 2023
Merged
feat: expose settings to configure default missing value interpretation.#2230yirutang merged 6 commits intogoogleapis:mainfrom
yirutang merged 6 commits intogoogleapis:mainfrom
Conversation
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
yirutang
approved these changes
Aug 16, 2023
yirutang
reviewed
Aug 17, 2023
| * <p>If this value is set to `DEFAULT_VALUE`, we will always populate default value if the | ||
| * field is missing from json and default value is defined in the column. | ||
| * | ||
| * <p>If this value is set to `NULL_VALUE`, we will always not populate default value. |
Contributor
There was a problem hiding this comment.
Change the comment of 'NULL_VALUE' to: we will always populate NULL to the missing fields, which is currently our default behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose a new API to configure the default missing value interpretation.
This value will affect the column that has default value defined, but not presented in the missing value map.
For JsonStreamWriter:
DEFAULT_VALUE, we will always populate default value if thefield is missing from json and default value is defined in the column.
NULL_VALUE, we will always not populate default value.For StreamWriter:
It will be the default configuration for the value not presented in the missing value map
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.