fix: Fixing the shutdown logic for streaming subscriber connection#1613
Merged
maitrimangal merged 3 commits intogoogleapis:mainfrom Jun 20, 2023
Merged
fix: Fixing the shutdown logic for streaming subscriber connection#1613maitrimangal merged 3 commits intogoogleapis:mainfrom
maitrimangal merged 3 commits intogoogleapis:mainfrom
Conversation
hannahrogers-google
suggested changes
Jun 13, 2023
Contributor
There was a problem hiding this comment.
I don't think we can do this. In runShutdown(), we call ackOperationsWaiter.waitComplete(). Which waits for all outstanding acks to be sent on the stub. If we close the stub before calling runShutdown, all remaining acks will all fail with the CancelledException.
Nevermind - I was thinking it was the stub we were shutting down. Shutting down the clientStream should be ok
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java
Show resolved
Hide resolved
hannahrogers-google
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1544
If you write sample code, please follow the samples format.