feat: add tracing for batchUpdate, executeUpdate, and connections#3097
Merged
feat: add tracing for batchUpdate, executeUpdate, and connections#3097
Conversation
Create one combined option for extended tracing, and disable this option by default for both the Connection API and the standard client.
rahul2393
approved these changes
May 13, 2024
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/TraceWrapper.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/DdlBatch.java
Show resolved
Hide resolved
...loud-spanner/src/test/java/com/google/cloud/spanner/connection/OpenTelemetryTracingTest.java
Show resolved
Hide resolved
Contributor
|
We should also update the Readme OpenTelemetry about the new Environment Variable and Option |
Collaborator
Author
Done |
…s/java-spanner into tracing-connection-api
surbhigarg92
approved these changes
May 14, 2024
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batchUpdatecalls in the Java client library (these calls were not traced).executeUpdatecalls in the Java client library (these calls were not traced).enableExtendedTracing, and might include additional features in the future.