feat: implement GrpcStorageImpl#deleteDefaultAcl#1807
Merged
BenWhitehead merged 1 commit intomainfrom Dec 15, 2022
Merged
Conversation
frankyn
reviewed
Dec 13, 2022
| .collect(ImmutableList.toImmutableList()); | ||
| if (newDefaultAcls.equals(currentDefaultAcls)) { | ||
| // we didn't actually filter anything out, no need to send an RPC, simply return false | ||
| return false; |
Contributor
There was a problem hiding this comment.
Add a comment into the Storage interface javadocs that calls out this particular case
Collaborator
Author
There was a problem hiding this comment.
What should we add to the javadocs?
This is sort of specific to the fact that we're emulating what was previously done via a single blind RPC.
Contributor
There was a problem hiding this comment.
Looks like I glossed over the need to make a request to get Acl List first; Why didn't you call the RPC to delete Acl instead of querying existing bucketdefaultAcl first?
Collaborator
Author
There was a problem hiding this comment.
We are patching the full default acl list of the bucket.
- We get the full list
- filter out any existing acl for the specified entity
- If there is no change, quickly return (this line)
- Otherwise, create an update bucket request
- Send update bucket request
- return true if the acl is no longer in the buckets default acl from the response
da718a5 to
cb0f538
Compare
3008c77 to
9d05192
Compare
9d05192 to
17be559
Compare
frankyn
approved these changes
Dec 15, 2022
Contributor
frankyn
left a comment
There was a problem hiding this comment.
Thanks for the clarification LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.