fix: make Blob and Bucket update diff aware#1994
Merged
BenWhitehead merged 3 commits intomainfrom Apr 28, 2023
Merged
Conversation
If a blob or bucket update does not actually contain a diff, instead of sending the empty update refresh the metadata. Add integration tests to verify behavior of updating object or bucket with no modification
| Opts<ObjectTargetOpt> opts = Opts.unwrap(options).resolveFrom(blobInfo).prepend(defaultOpts); | ||
| Opts<ObjectTargetOpt> unwrap = Opts.unwrap(options); | ||
| if (blobInfo.getModifiedFields().isEmpty()) { | ||
| return internalBlobGet(blobInfo.getBlobId(), unwrap.constrainTo(ObjectSourceOpt.class)); |
Contributor
There was a problem hiding this comment.
so the behavior here is if the fields are not being modified we just perform a get and return the unmodified blob?
Collaborator
Author
There was a problem hiding this comment.
Correct, while attempting to use those provided options that also can apply to Get
sydney-munro
approved these changes
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Blob or Bucket update does not actually contain a diff, instead of sending the empty update refresh the metadata.
Add integration tests to verify behavior of updating object or bucket with no modification