feat: Adds a ZeroCopy response marshaller for grpc ReadObject handling#2489
Merged
JesseLovelace merged 11 commits intomainfrom Apr 14, 2024
Merged
feat: Adds a ZeroCopy response marshaller for grpc ReadObject handling#2489JesseLovelace merged 11 commits intomainfrom
JesseLovelace merged 11 commits intomainfrom
Conversation
BenWhitehead
reviewed
Apr 4, 2024
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
Show resolved
Hide resolved
BenWhitehead
previously requested changes
Apr 9, 2024
Collaborator
BenWhitehead
left a comment
There was a problem hiding this comment.
Can you purge out the owlbot samples formatting, and readme edits updates? They're adding noise to the PR. Other than that, a few minor things.
...cloud-storage/src/main/java/com/google/cloud/storage/GapicUnbufferedReadableByteChannel.java
Outdated
Show resolved
Hide resolved
...cloud-storage/src/main/java/com/google/cloud/storage/GapicUnbufferedReadableByteChannel.java
Outdated
Show resolved
Hide resolved
...cloud-storage/src/main/java/com/google/cloud/storage/GapicUnbufferedReadableByteChannel.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
Show resolved
Hide resolved
Comment on lines
+874
to
+875
| // todo: this is fragile to proto annotation changes, and would require manual | ||
| // maintenance | ||
| builder.add(request.getBucket(), "bucket", PathTemplate.create("{bucket=**}")); |
Collaborator
There was a problem hiding this comment.
Any thoughts on how we can deal with this TODO? (the todo itself doesn't need to be addressed now, just starting the thought exercise)
Contributor
There was a problem hiding this comment.
Filed FR against GAPIC for this: googleapis/sdk-platform-java#2501
Could point to this in the mean time?
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
Show resolved
Hide resolved
…pcStorageOptions.java Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
4ffd639 to
4ad2a62
Compare
…haller#close() handling of multiple IOExceptions
google-cloud-storage/src/test/java/com/google/cloud/storage/ZeroCopyMarshallerTest.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/ZeroCopyMarshallerTest.java
Outdated
Show resolved
Hide resolved
No longer blocking. A couple nits, anyone else can approve
frankyn
approved these changes
Apr 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Zero Copy ReadObject marshaller for grpc and some basic tests