Skip to content

docs(samples): Update the Recovery Point Objective (RPO) sample output#725

Merged
gcf-merge-on-green[bot] merged 6 commits intogoogleapis:mainfrom
rebecca-pete:rebecca-pete-python-samples-patch-1
May 20, 2022
Merged

docs(samples): Update the Recovery Point Objective (RPO) sample output#725
gcf-merge-on-green[bot] merged 6 commits intogoogleapis:mainfrom
rebecca-pete:rebecca-pete-python-samples-patch-1

Conversation

@rebecca-pete
Copy link
Contributor

@rebecca-pete rebecca-pete commented Mar 5, 2022

@ddelgrosso1 Related to b/217259317.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rebecca-pete rebecca-pete requested review from a team as code owners March 5, 2022 02:12
@product-auto-label product-auto-label bot added api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Mar 5, 2022
@parthea parthea changed the title Rebecca pete python samples patch 1 docs(samples): Update the Recovery Point Objective (RPO) sample output Mar 5, 2022
@parthea parthea requested a review from ddelgrosso1 March 5, 2022 16:48
@cojenco
Copy link
Contributor

cojenco commented Mar 8, 2022

Thanks @rebecca-pete for the changes!

Could you help check if we need to update the other RPO samples and the docstrings here? There are 4 RPO samples in total; please see previous PR for reference. I can help fix the failing tests as we're asserting the output string.

@parthea parthea assigned rebecca-pete and unassigned cojenco and ddelgrosso1 Mar 30, 2022
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 19, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 19, 2022
@rebecca-pete rebecca-pete requested a review from a team as a code owner May 20, 2022 17:13
cojenco
cojenco approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @ddelgrosso1 and @rebecca-pete

@cojenco cojenco added the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit b0bf411 into googleapis:main May 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2022
@release-please release-please bot mentioned this pull request May 20, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddelgrosso1 ddelgrosso1 Awaiting requested review from ddelgrosso1

1 more reviewer

@cojenco cojenco cojenco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rebecca-pete rebecca-pete

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rebecca-pete @cojenco @ddelgrosso1