feat: add dual region bucket support and sample#748
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
danielbankhead
left a comment
There was a problem hiding this comment.
LGTM, one nit - we'll want to update references from 'dual region' to 'dual-region'
|
Update - Python samples projects have been added to the allowlist (internal cl/438869140). Awaiting for deployment in the next 2 weeks. |
@danielbankhead thanks for the review! Do you mean updating the docstrings in client.py? |
|
Yep, correct |
Updated the docstrings and the docs link as discussed in java thread. |
|
Note(04.06.2022): Dual-region storage is currently a Pre-GA feature https://cloud.google.com/storage/docs/dual-regions |
| (Optional) The location of the bucket. If not passed, | ||
| the default location, US, will be used. See | ||
| https://cloud.google.com/storage/docs/bucket-locations | ||
| the default location, US, will be used. If specifying a dual-region, |
There was a problem hiding this comment.
May I suggest the following:
(Optional) The location of the bucket. If not passed, the default location, 'US', will be used. If specifying a dual-region location, the regions can be specified by joining them with a plus sign, for example 'US-CENTRAL1+US-WEST1'. See:
https://cloud.google.com/storage/docs/locations
Add dual region bucket support and sample
client.create_bucket()accepts a dual-regionlocationas a string with 2 regions concatenated with a '+' (e.g."US-EAST1+US-WEST1")Fixes #739 🦕